Make isView safe outside of Builder context (#4228)

chipsalliance · Jun 28, 2024 · 219a237 · 219a237
1 parent 2fdaead
commit 219a237
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/core/src/main/scala/chisel3/experimental/dataview/package.scala b/core/src/main/scala/chisel3/experimental/dataview/package.scala
@@ -273,7 +273,7 @@ package object dataview {
   }
 
   // Safe for all Data
-  private[chisel3] def isView(d: Data): Boolean = d._parent.contains(ViewParent)
+  private[chisel3] def isView(d: Data): Boolean = d._parent.exists(_ == ViewParent)
 
   /** Turn any [[Element]] that could be a View into a concrete Element
     *

diff --git a/src/test/scala/chiselTests/UIntOps.scala b/src/test/scala/chiselTests/UIntOps.scala
@@ -275,6 +275,11 @@ trait ShiftRightWidthBehavior { self: ChiselRunners =>
 
 class UIntOpsSpec extends ChiselPropSpec with Matchers with Utils with ShiftRightWidthBehavior {
 
+  // This is intentionally a val outside of any ScalaTest constructs to check that it is legal
+  // to create a literal outside of a Chisel context and *before* any Chisel contexts have been created
+  // in this thread.
+  val five = 5.U
+
   property("Bools can be created from 1 bit UInts") {
     ChiselStage.emitCHIRRTL(new GoodBoolConversion)
   }