Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(find_jump): check for empty query results #128

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Conversation

anjakefala
Copy link
Contributor

Closes #127.

@ssiegelx
Copy link
Contributor

This is a reasonable thing to do, but I don't think it fixes the underlying issue. The query should not be empty because there are chimecal files in /mnt/gong/staging. For some reason these files are not being added to the database when the refresh_archive_index method is called.

@anjakefala
Copy link
Contributor Author

This is a reasonable thing to do, but I don't think it fixes the underlying issue. The query should not be empty because there are chimecal files in /mnt/gong/staging. For some reason these files are not being added to the database when the refresh_archive_index method is called.

Thanks for further clarification on why the query is coming back empty! I will take a further look.

@anjakefala anjakefala self-assigned this Oct 25, 2019
@anjakefala anjakefala added WIP bug Something isn't working labels Oct 25, 2019
@anjakefala
Copy link
Contributor Author

For updates in what is happening here, find_jump was looking for the archive_index.db in /mnt/gong/not_archived which has been deprecated. The underlying issue is hopefully being fixed here: https://github.com/chime-experiment/dias/pull/130/files Do we still want error handling/notifications when this issue comes up? Or shall we close?

Copy link
Contributor

@nritsche nritsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand from the comments here that "the underlying issue" has been fixed elsewhere. But since the SQL query generally can result in Nones, it can't be wrong to check and handle that case.

@anjakefala anjakefala merged commit 37920d0 into master Dec 14, 2019
@anjakefala anjakefala deleted the kef/find_jump branch December 16, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in find_jump
3 participants