build: use setuptools-git-versioning for versioning #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
approved these changes
Jul 19, 2024
The versioneer file here was never updated for 3.12. Instead of doing that now, I think setuptools-git-versioning will be a better way of doing it, since there's no in-repo code to fall out of date anymore. I've used setuptools-git-versioning already in other things (see `alpenhorn-chime`) and it seems like less of a burden than versioneer has been.
ketiltrout
force-pushed
the
setuptools-git-versioning
branch
from
ce7fec7
to
f767a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set min python version to 3.8.
The versioneer file here was never updated for 3.12. Instead of doing that now, I think setuptools-git-versioning will be a
better way of doing it, since there's no in-repo code to fall out of date anymore.
I've used setuptools-git-versioning already in other things (see
alpenhorn-chime) and it seems like less of a burden than versioneer has been.