Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ss/timing rt update #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ss/timing rt update #20

wants to merge 2 commits into from

Conversation

ssiegelx
Copy link

Adds a new timing acquisition, which contains the timing correction generated by the real-time pipeline.

Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few fiddly things missing here, some of which will become apparent when you do the alpenhorn additions, but other bits are for Finder support:

  • in class ArchiveAcq in orm.py, you need to:
    • add a new function timing_files that returns self.files.join(TimingFileInfo)
    • add this timing_files function to the methods timed_files and n_timed_files
  • for util.py:
    • in populate_types, in addition to the AcqType entry you added, you also need to add an entry to the FileType initialiser following
    • create a parse_timingfile_name (which you'll need to use in your alpenhorn additions), which at minimum raises db.ValidationError if the filename isn't correct.
    • add detection logic to detect_file_type so that it will return the correct FileType given the name of a TimingFile.

@ketiltrout
Copy link
Member

ketiltrout commented May 12, 2022

There's a deficiency in detect_file_type which I think you're going to run in to: each FileType needs a unique regex for its filenames. This is why we had to add hfb_ to the absorber file names.

It's not ideal. One way to fix it would be to add the acq_type to the call, which has already been determined by the time this function is called by alpenhorn, and which could be used to resolve ambiguities with identical regexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants