Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up orm/get classes in chimedb.dataset.get #8

Merged
merged 5 commits into from
Jun 29, 2020
Merged

Conversation

nritsche
Copy link
Collaborator

  • If data wasn't pre-fetched, the orm (low level) state was used as get.Dataset.dataset_state -> always use get.DatasetState here
  • If data wasn't pre-fetched, the state type name was used as get.Dataset.type instead of the type object -> always use get.DatasetStateType here
  • add check for types of the parameters of get.Dataset.from_id
  • add tests

@nritsche nritsche added the bug Something isn't working label Jun 24, 2020
@nritsche nritsche self-assigned this Jun 24, 2020
@ssiegelx
Copy link

I am still getting that same error when I try the following with this branch:

import chimedb.dataset as ds
import chimedb.core as core

core.connect()

idd = 'acb008ea826505544a10a0ad97d533ba'
res = ds.Dataset.from_id(idd)
fmap = res.closest_ancestor_of_type("f_engine_frequency_map")

But if I pre-fetch and cache using ds.get.index() before querying the dataset, then it works fine.

@nritsche
Copy link
Collaborator Author

I am still getting that same error when I try the following with this branch:

import chimedb.dataset as ds
import chimedb.core as core

core.connect()

idd = 'acb008ea826505544a10a0ad97d533ba'
res = ds.Dataset.from_id(idd)
fmap = res.closest_ancestor_of_type("f_engine_frequency_map")

But if I pre-fetch and cache using ds.get.index() before querying the dataset, then it works fine.

Thanks @ssiegelx !
It should work now.

@ssiegelx
Copy link

Thanks @nritsche! This is working for me now.

@nritsche nritsche merged commit 145132e into master Jun 29, 2020
@nritsche nritsche deleted the rn/baseds branch June 29, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants