Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Lint code with ruff #81

Merged
merged 1 commit into from
Aug 2, 2024
Merged

CI: Lint code with ruff #81

merged 1 commit into from
Aug 2, 2024

Conversation

ketiltrout
Copy link
Member

@ketiltrout ketiltrout commented Aug 2, 2024 •
edited
Loading

I need to look at the except Exception fixes a bit more.

@ketiltrout ketiltrout marked this pull request as draft August 2, 2024 18:17
@ketiltrout ketiltrout requested review from rikvl and ljgray August 2, 2024 20:25
@ketiltrout ketiltrout marked this pull request as ready for review August 2, 2024 20:25
@ketiltrout ketiltrout changed the title ruffage CI: Lint code with ruff Aug 2, 2024
ketiltrout
ketiltrout commented Aug 2, 2024
View reviewed changes
ch_util/andata.py Outdated Show resolved Hide resolved
ljgray
ljgray approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@ljgray ljgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine other than my comments

.github/workflows/main.yml Show resolved Hide resolved
ch_util/cal_utils.py Show resolved Hide resolved
ch_util/data_index.py Show resolved Hide resolved
@ketiltrout ketiltrout merged commit 54c02c4 into master Aug 2, 2024
5 checks passed
@ketiltrout ketiltrout deleted the ruff branch August 2, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssiegelx ssiegelx ssiegelx left review comments

@ljgray ljgray ljgray approved these changes

@rikvl rikvl Awaiting requested review from rikvl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ketiltrout @ssiegelx @ljgray