refactor(ephemeris): Use ch_ephem #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The checks won't work until the other PRs are merged. |
ljgray
approved these changes
Jul 25, 2024
ketiltrout
force-pushed
the
ch_ephem
branch
4 times, most recently
from
c03fe4c
to
a4ad3f2
Compare
|
I had a look at moving the HFB catalog. That looks fine to me. Apologies for the delay! |
ketiltrout
force-pushed
the
ch_ephem
branch
3 times, most recently
from
5da720d
to
8ee69f6
Compare
This re-imports stuff moved to `ch_ephem`. It both re-imports everything that was moved back into `ch_util.ephemeris` for backwards compatibility, but also removes references to `ch_util.epheremis` from the code, using the newly-exported versions of things directly. This PR requires both: * radiocosmology/caput#271 * chime-experiment/ch_ephem#1 Catalogs: All the catalogs have been moved to `ch_ephem`, which provides a standard interface to them via `ch_ephem.catalogs.load`. To make this change, `fluxcat.FluxCatalog.load` has been broken into two pieces. The new `fluxcat.FluxCatalog.load_dict` imports a catalog from an already-parsed JSON dict (which is what `ch_ephem` provides). The original `fluxcat.FluxCatalog.load` works as it used to, but tail-calls `load_dict` to do most of the importing. Position data: Position data (lat, lon, alt) is now obtained by fetching the parameter out of the `caput.time.Observer` objects provided by `ch_ephem`. The constants in `ch_util.ephemeris` are populated by doing this. Instrument geormetry: `ch_ephem` has also taken on the geometry data (rotation, roll, offset) that was in `tools` (where it's been re-imported from `ch_ephem`). Private objects deleted: I've also deleted a number of private objects which are no longer being used (i.e. objects whose names start with a leading underscore). Notable among these are the geometry constants from `ch_util.tools` and the unused`ch_util.tools._LAT_LON` which had position data for various instruments which differed from the position data provided by `ch_util.ephemeris`. Also removed are the long-deprectated `ch_util.ephemeris._get_chime` and `ch_util.ephemeris.transit_RA`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-imports stuff moved to
ch_ephem. It both re-imports everything that was moved back intoch_util.ephemerisfor backwards compatibility, but also removes references toch_util.epheremisfrom the code, using the newly-exported versions of things directly.This PR requires both:
Catalogs:
All the catalogs have been moved to
ch_ephem, which provides a standard interface to them viach_ephem.catalogs.load. To make this change,fluxcat.FluxCatalog.loadhas been broken into two pieces. The newfluxcat.FluxCatalog.load_dictimports a catalog from an already-parsed JSON dict (which is whatch_ephemprovides). The originalfluxcat.FluxCatalog.loadworks as it used to, but tail-callsload_dictto do most of the importing.Position data:
Position data (lat, lon, alt) is now obtained by fetching the parameter out of the
caput.time.Observerobjects provided bych_ephem. The constants inch_util.ephemerisare populated by doing this.Instrument rotation:
ch_ephemhas also taken on the rotation data that was intools(where it's been re-imported fromch_ephem). Not sure this is ideal. Please comment on thech_ephemPR if you can provide an opinion on this.Private objects deleted:
I've also deleted a number of private objects which are no longer being used (i.e. objects whose names start with a leading underscore).
Notable among these is the unused
ch_util.tools._LAT_LONwhich had position data for various instruments which differed from the position data provided bych_util.ephemeris.Also removed are the long-deprectated
ch_util.ephemeris._get_chimeandch_util.ephemeris.transit_RA.