Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rfi): remove automatic timestemp set and move default instrument to argument #61

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Jun 22, 2023

Setting the default timestamp to time.time() would potentially break compatibility with the cosmology daily pipeline since the current time does not necessarily have any relation to the CSD being processed.

For example, if an old day did not provide a timestamp, a band which has turned off since then would not get flagged when using the current time as a timestamp even though the band was still active when that data was collected.

I'm not sure if using the current time is needed for outrigger masking - if so, it should probably be moved to a separate place so that we maintain compatibility with the analysis pipeline.

Copy link
Contributor

@aelanman aelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, and apologies for introducing this error in the first place. I was getting an error before when the timestamp wasn't set, because (as I recall) in an earlier version it just did a comparison to the timestamp, and comparing a float to None raised an error.
The timestamp isn't currently used for outriggers, so it makes no difference there.

@aelanman aelanman merged commit b6fa25a into master Jun 23, 2023
@aelanman aelanman deleted the ljg/time-fix branch June 23, 2023 00:03
@ljgray
Copy link
Contributor Author

ljgray commented Jun 23, 2023

Thanks! Originally it didn't support setting end times since I just assumed none of the bands would actually turn off... So the comparison would have been different and would have worked fine at that point using the current time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants