fix(rfi): remove automatic timestemp set and move default instrument to argument #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the default timestamp to
time.time()
would potentially break compatibility with the cosmology daily pipeline since the current time does not necessarily have any relation to the CSD being processed.For example, if an old day did not provide a timestamp, a band which has turned off since then would not get flagged when using the current time as a timestamp even though the band was still active when that data was collected.
I'm not sure if using the current time is needed for outrigger masking - if so, it should probably be moved to a separate place so that we maintain compatibility with the analysis pipeline.