Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cal_utils): class for fitting polynomial to real and imag component #40

Merged
merged 5 commits into from
Nov 22, 2022
Merged

feat(cal_utils): class for fitting polynomial to real and imag component #40

merged 5 commits into from
Nov 22, 2022

Conversation

ssiegelx
Copy link
Contributor

Used to fit the cross-polar holography response.

tristpinsm
tristpinsm previously approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@tristpinsm tristpinsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this framework but I read through and didn't find anything to note, except for a docstring typo.

ch_util/cal_utils.py Outdated Show resolved Hide resolved
@ssiegelx ssiegelx merged commit fbf1cb2 into master Nov 22, 2022
@ssiegelx ssiegelx deleted the ss/fit_crosspol branch November 22, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristpinsm tristpinsm tristpinsm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssiegelx @tristpinsm