ss/narrowband-gain-error #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check if data is complex. If not, do not perform GPR on imag part. - Set appropriate boundaries for the variance of the kernel. Previous defaults were not valid under some circumstances.
tristpinsm
reviewed
Aug 12, 2022
added 2 commits
September 5, 2022 16:28
- Ensure consistent predicted error on interpolated gains for different versions of sklearn. - Add note about algorithm used to construct high-pass filter.
|
Thanks @tristpinsm! I have addressed your comments. |
tristpinsm
previously approved these changes
Sep 6, 2022
... and earlier versions.
tristpinsm
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new method
rfi.iterative_hpf_maskingthat implements the algorithm used to identify narrowband features in the gains. I am putting it inch_utilin case we want to use it in the real-time pipeline in the future.Also makes a few modifications to
cal_utils.interpolate_gainto make it work with the pipeline used to flag these features.