Switch DirectBootMigrationService to a background service #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seem to be two issues with the foreground service: * Some Android builds seem to be broken and throw a ForegroundServiceDidNotStartInTimeException even though the service unconditionally calls startForeground() in onStartCommand(). The root cause of this is unknown. Perhaps these devices are exceptionally slow during boot? * The persistent notification does not get dismissed when the file migration runs too quickly. We may be able to work around the second issue by not setting the FOREGROUND_SERVICE_IMMEDIATE notification behavior flag, but given how fast the file migration is, let's just switch to a background service. We're unlikely to hit Android's limitations on background services. Closes: #574 Closes: #576 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be two issues with the foreground service:
We may be able to work around the second issue by not setting the FOREGROUND_SERVICE_IMMEDIATE notification behavior flag, but given how fast the file migration is, let's just switch to a background service. We're unlikely to hit Android's limitations on background services.
Closes: #574
Closes: #576