Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vietnamese trans #543

Merged
merged 1 commit into from
May 19, 2024
Merged

Add Vietnamese trans #543

merged 1 commit into from
May 19, 2024

Conversation

hdzungx
Copy link
Contributor

@hdzungx hdzungx commented May 17, 2024

No description provided.

@chenxiaolong
Copy link
Owner

Thanks for the PR! Please also add vi to the list here:

BCR/app/build.gradle.kts

Lines 121 to 137 in fc69288

resourceConfigurations.addAll(listOf(
"de",
"en",
"es",
"fr",
"hi",
"it",
"iw",
"pl",
"pt-rPT",
"ru",
"sk",
"tr",
"uk",
"zh-rCN",
"zh-rTW",
))

and here:

<locale-config xmlns:android="http://schemas.android.com/apk/res/android">
<locale android:name="de" />
<locale android:name="en" />
<locale android:name="es" />
<locale android:name="fr" />
<locale android:name="hi" />
<locale android:name="it" />
<locale android:name="iw" />
<locale android:name="pl" />
<locale android:name="pt-rPT" />
<locale android:name="ru" />
<locale android:name="sk" />
<locale android:name="tr" />
<locale android:name="uk" />
<locale android:name="zh-rCN" />
<locale android:name="zh-rTW" />
</locale-config>

This is necessary for Vietnamese to work for Android 13+'s per-app language feature.

@chenxiaolong chenxiaolong self-assigned this May 18, 2024
@hdzungx
Copy link
Contributor Author

hdzungx commented May 19, 2024

Thanks. Added. Please merge it.

@chenxiaolong chenxiaolong merged commit 9a45fb9 into chenxiaolong:master May 19, 2024
1 check passed
chenxiaolong added a commit that referenced this pull request May 19, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants