Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(import): validate that attachment contents is a Buffer #159

Merged
merged 3 commits into from
Oct 5, 2018
Merged

fix(import): validate that attachment contents is a Buffer #159

merged 3 commits into from
Oct 5, 2018

Conversation

targos
Copy link
Member

@targos targos commented Oct 5, 2018

Fixes: #158

@targos targos requested a review from stropitek October 5, 2018 07:54
stropitek
stropitek reviewed Oct 5, 2018
View reviewed changes
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not add a test that uses a typed array instead of a Buffer?

@targos
Copy link
Member Author

targos commented Oct 5, 2018

@stropitek done

@stropitek
Copy link
Contributor

Should we consider this a fix or a breaking change?

base64 strings were accepted and will fail now

@targos targos merged commit f7b2ce2 into master Oct 5, 2018
@targos
Copy link
Member Author

targos commented Oct 5, 2018

Should we consider this a fix or a breaking change?

I marked it as breaking

@targos targos deleted the fix-158 branch October 5, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stropitek stropitek stropitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@targos @stropitek