-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rails autoloader version to 6.0 #2392
Merged
saghoshprogress
merged 8 commits into
main
from
rajeshPaul38--upgrade-rails-autoloader-version-2378
Nov 24, 2021
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c6b50c8
using autoloader 6.0; fixed faker syntax
RajeshPaul38 32eaca4
upgraded redis-rails gem version from 1.6 to 1.9; set cache_versionin…
RajeshPaul38 2da7371
removed --without flag as it is deprecated
RajeshPaul38 493e10e
pinning gem "ddtrace" to version "0.53.0" as 0.54.0 throws error
RajeshPaul38 52dd002
pinned ddtrace to version 0.53.0 and execjs to 2.7.0 as upgrade of th…
RajeshPaul38 cec7b38
class naming convention fix;
RajeshPaul38 49c4e46
added missing fix
RajeshPaul38 13a50ac
lint issue fix
RajeshPaul38 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
require "openssl" | ||
|
||
module Supermarket | ||
class FIPS | ||
class Fips | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new autoloader zeitwerk imposes some strict naming conventions. Hence this change. |
||
# FIPS 140-2 Annex A references NIST Digital Signature Standard (DSS), | ||
# FIPS Publication 186-4 to identify several algorithms as the | ||
# Secure Hash Standard (SHS). Algorithms listed here are in the SHS | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
if ENV["OPENSSL_FIPS"] == "1" | ||
Supermarket::FIPS.enable! | ||
Supermarket::Fips.enable! | ||
Rails.logger.info "FIPS 140-2 mode is enabled." | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,7 +84,7 @@ | |
cookbook_version = cookbook.cookbook_versions.where( | ||
version: "0.#{version_number}.0" | ||
).first_or_initialize( | ||
description: Faker::Lorem.sentences(1).first, | ||
description: Faker::Lorem.sentences(number: 1).first, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. new syntax for faker |
||
license: 'MIT', | ||
tarball: File.open('spec/support/cookbook_fixtures/redis-test-v1.tgz'), | ||
readme: '# This is a README', | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinned to 0.53 because 0.54 has some breaking change