-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rails autoloader version to 6.0 #2392
Upgrade rails autoloader version to 6.0 #2392
Conversation
…g to false Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
…ese are causing failures in build
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
👷 Deploy Preview for chef-supermarket processing. 🔨 Explore the source changes: 13a50ac 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/619ca258fe0948000838b89f |
Simplecov Report
|
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -16,7 +16,7 @@ gem "sidekiq-cron" | |||
gem "aws-sdk-s3" | |||
gem "chef", "~> 17.7", require: false | |||
gem "compass-rails" | |||
gem "ddtrace", require: false | |||
gem "ddtrace", "0.53.0", require: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinned to 0.53 because 0.54 has some breaking change
@@ -2,7 +2,7 @@ | |||
require "openssl" | |||
|
|||
module Supermarket | |||
class FIPS | |||
class Fips |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new autoloader zeitwerk imposes some strict naming conventions. Hence this change.
@@ -84,7 +84,7 @@ | |||
cookbook_version = cookbook.cookbook_versions.where( | |||
version: "0.#{version_number}.0" | |||
).first_or_initialize( | |||
description: Faker::Lorem.sentences(1).first, | |||
description: Faker::Lorem.sentences(number: 1).first, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new syntax for faker
Description
Rails 6 has introduced a new autoloader: zeitwerk which is the default autoloader in autoloader version 6
Issues Resolved
#2378
Check List