Upgrade rails autoloader version to 6.0 #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to false Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
…ese are causing failures in build
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
|
👷 Deploy Preview for chef-supermarket processing. 🔨 Explore the source changes: 13a50ac 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/619ca258fe0948000838b89f |
Simplecov Report
|
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
RajeshPaul38
changed the title
saghoshprogress
deleted the
rajeshPaul38--upgrade-rails-autoloader-version-2378
branch
RajeshPaul38
commented
Nov 24, 2021
| @@ -16,7 +16,7 @@ gem "sidekiq-cron" | |||
| gem "aws-sdk-s3" | |||
| gem "chef", "~> 17.7", require: false | |||
| gem "compass-rails" | |||
| gem "ddtrace", require: false | |||
| gem "ddtrace", "0.53.0", require: false | |||
There was a problem hiding this comment.
pinned to 0.53 because 0.54 has some breaking change
RajeshPaul38
commented
Nov 24, 2021
| @@ -2,7 +2,7 @@ | |||
| require "openssl" | |||
|
|
|||
| module Supermarket | |||
| class FIPS | |||
| class Fips | |||
There was a problem hiding this comment.
The new autoloader zeitwerk imposes some strict naming conventions. Hence this change.
RajeshPaul38
commented
Nov 24, 2021
| @@ -84,7 +84,7 @@ | |||
| cookbook_version = cookbook.cookbook_versions.where( | |||
| version: "0.#{version_number}.0" | |||
| ).first_or_initialize( | |||
| description: Faker::Lorem.sentences(1).first, | |||
| description: Faker::Lorem.sentences(number: 1).first, | |||
There was a problem hiding this comment.
new syntax for faker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rails 6 has introduced a new autoloader: zeitwerk which is the default autoloader in autoloader version 6
Issues Resolved
#2378
Check List