Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Sprockets [CVE-2018-3760] #1743

Merged
merged 1 commit into from
Jul 1, 2018
Merged

Conversation

pwelch
Copy link
Contributor

@pwelch pwelch commented Jul 1, 2018

Upgrade the Sprockets gem to patch for
CVE-2018-3760

The actual sprockets CVE doesn't affect Supermarket because it does
not do asset compilation during the request/response cycle. However,
this will upgrade the gem to clear a bundle-audit failure.

Fixes #1742

@pwelch pwelch requested a review from a team July 1, 2018 14:52
@pwelch pwelch mentioned this pull request Jul 1, 2018
@pwelch pwelch force-pushed the GH1742-upgrade-sprockets-gem branch from 666a2bb to a098af3 Compare July 1, 2018 14:55
@pwelch pwelch self-assigned this Jul 1, 2018
Upgrade the Sprockets gem to patch for
[CVE-2018-3760](https://nvd.nist.gov/vuln/detail/CVE-2018-3760)

The actual sprockets CVE doesn't affect Supermarket because it does
not do asset compilation during the request/response cycle. However,
this will upgrade the gem to clear a bundle-audit failure.

Also upgrades fieri gem because it depends on Sprockets.

Fixes #1742

Signed-off-by: pwelch <pwelch@chef.io>
@pwelch pwelch force-pushed the GH1742-upgrade-sprockets-gem branch from a098af3 to 950923c Compare July 1, 2018 15:05
@pwelch pwelch requested a review from robbkidd July 1, 2018 15:16
Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now is the time on sprockets when we dance

@robbkidd robbkidd merged commit 590f7f8 into master Jul 1, 2018
@robbkidd robbkidd deleted the GH1742-upgrade-sprockets-gem branch July 1, 2018 18:19
@tas50 tas50 added Status: Incomplete A pull request that is not ready to be merged as noted by the author. and removed in progress labels Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Incomplete A pull request that is not ready to be merged as noted by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants