Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Foodcritic to 14 #1741

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Update Foodcritic to 14 #1741

merged 1 commit into from
Jul 2, 2018

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jun 29, 2018

Signed-off-by: Tim Smith tsmith@chef.io

@tas50 tas50 requested a review from a team June 29, 2018 19:22
@pwelch
Copy link
Contributor

pwelch commented Jul 1, 2018

This is failing because bundle-audit caught an outdated version of the sprockets gem. While we are not vulnerable to this particular sprockets CVE, the branch to clear the bundler-audit failure is here: #1743

@tas50
Update Foodcritic to 14
8111e65 
Signed-off-by: Tim Smith <tsmith@chef.io>
@pwelch
Copy link
Contributor

pwelch commented Jul 2, 2018

Rebased with latest master which has a fix for the sprockets CVE bundler-audit failure.

@pwelch pwelch self-requested a review July 2, 2018 13:17
pwelch
pwelch approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@pwelch pwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tas50 tas50 merged commit 5f63200 into master Jul 2, 2018
@pwelch pwelch deleted the fc_bump2 branch July 2, 2018 20:05
@tas50 tas50 added Status: Incomplete A pull request that is not ready to be merged as noted by the author. and removed in progress labels Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwelch pwelch pwelch approved these changes

Assignees
No one assigned
Labels
Status: Incomplete A pull request that is not ready to be merged as noted by the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tas50 @pwelch @robbkidd