Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add latest rust #957

Merged
merged 1 commit into from
Jun 7, 2018
Merged

add latest rust #957

merged 1 commit into from
Jun 7, 2018

Conversation

thommay
Copy link
Contributor

@thommay thommay commented Jun 4, 2018

No description provided.

@thommay thommay requested a review from a team as a code owner June 4, 2018 16:56
@tyler-ball
Copy link
Contributor

Should we also update the default_version or does that normally occur some other time?

Copy link
Contributor

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built both ChefDK and Chef Workstation (when I overrode the Rust version) on everything but Windows.

Windows fails with

Progress: |       [NetFetcher: rust] I | 2018-06-04T19:19:14+00:00 | Retrying failed download due to 403 Forbidden (1 retries left)...

Still have my question about changing the default_version but this looks to work!

Signed-off-by: Thom May <thom@chef.io>
@thommay
Copy link
Contributor Author

thommay commented Jun 5, 2018

Updated the default version

@thommay
Copy link
Contributor Author

thommay commented Jun 5, 2018

@scotthain are the windows build nodes not set up to update the omnibus cache? That seems to be what the above failure is:

[NetFetcher: rust] I | 2018-06-04T19:19:12+00:00 | Downloading from `https://opscode-omnibus-cache.s3.amazonaws.com/rust-1.26.1-35693cab9c254e04d3085f7f4566c353e70e23cd1be83c1ff6a32efc1b69769c'
[NetFetcher: rust] I | 2018-06-04T19:19:14+00:00 | Retrying failed download due to 403 Forbidden (3 retries left)...

Progress: |       [NetFetcher: rust] I | 2018-06-04T19:19:14+00:00 | Retrying failed download due to 403 Forbidden (2 retries left)...

Progress: |       [NetFetcher: rust] I | 2018-06-04T19:19:14+00:00 | Retrying failed download due to 403 Forbidden (1 retries left)...

@thommay thommay merged commit 54478c0 into master Jun 7, 2018
tyler-ball added a commit to chef/chef-workstation that referenced this pull request Jun 7, 2018
To fix our build by consuming chef/omnibus-software#957

Signed-off-by: tyler-ball <tyleraball@gmail.com>
@tas50 tas50 deleted the tm/new_rust branch April 1, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants