add Chef/NodeSet cop with autocorrect #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autocorrects to node.normal. we need a Chef/NodeNormal to warn about that, but this is a tiny bit of progress. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
lamont-granquist
force-pushed
the
lcg/node-set
branch
from
56dc34e
to
d97de18
Compare
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
lamont-granquist
force-pushed
the
lcg/node-set
branch
from
120fa43
to
ba307fc
Compare
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
tas50
reviewed
Jul 12, 2019
|
|
||
| def on_send(node) | ||
| node_set?(node) do | ||
| add_offense(node, location: :expression, message: MSG, severity: :error) |
There was a problem hiding this comment.
these new rules need to be warning level for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autocorrects to node.normal.
we need a Chef/NodeNormal to warn about that, but this is a tiny bit
of progress.