-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add Chef/NodeSet cop with autocorrect
autocorrects to node.normal. we need a Chef/NodeNormal to warn about that, but this is a tiny bit of progress.
- Loading branch information
1 parent
a272f10
commit 56dc34e
Showing
3 changed files
with
64 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
# | ||
# Copyright:: Copyright 2001-2019, Chef Software Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
module RuboCop | ||
module Cop | ||
module Chef | ||
# The node.set method has been removed in Chef-13 and must be replaced by node.normal. | ||
# | ||
# Note that node.normal keeps the semantics identical, but the use of node.normal is | ||
# also discouraged. | ||
# | ||
# @example | ||
# | ||
# # bad | ||
# node.set['foo'] = true | ||
# | ||
# # good | ||
# node.normal['foo'] = true | ||
# | ||
class NodeSet < Cop | ||
MSG = 'Do not use node.set'.freeze | ||
|
||
def_node_matcher :node_set?, <<-PATTERN | ||
(send (send _ :node) :set) | ||
PATTERN | ||
|
||
def on_send(node) | ||
node_set?(node) do | ||
add_offense(node, location: :expression, message: MSG, severity: :error) | ||
end | ||
end | ||
|
||
def autocorrect(node) | ||
lambda do |corrector| | ||
corrector.replace(node.loc.expression, "node.normal") | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end |