Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autocorrection of multiple platform helpers in a recipe #303

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Fix autocorrection of multiple platform helpers in a recipe #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/rubocop/cop/chef/style/use_platform_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,16 @@ class UsePlatformHelpers < Cop
PATTERN

def on_send(node)
platform_check?(node) do |type, plat|
# set these so we can use them in the auto_correct method
@type = type
@plat = plat

platform_check?(node) do
add_offense(node, location: :expression, message: MSG, severity: :refactor)
end
end

def autocorrect(node)
lambda do |corrector|
corrector.replace(node.loc.expression, "#{@type.value}?('#{@plat.value}')")
platform_check?(node) do |type, plat|
corrector.replace(node.loc.expression, "#{type.value}?('#{plat.value}')")
end
end
end
end
Expand Down