Fix autocorrection of multiple platform helpers in a recipe #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a major facepalm here and looking back it makes total sense. All the on_* hooks run and then all the autocorrects run. That means when I set @type and @plat they'd get used by all the autocorrectors and every node['platform' ] == 'foo' would be autocorrected to the last platform found in the recipe. Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
fix_platform_bug
branch
from
f955cfd
to
0ac9f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major facepalm here and looking back it makes total sense. All the on_* hooks run and then all the autocorrects run. That means when I set @type and @plat they'd get used by all the autocorrectors and every node['platform'
] == 'foo' would be autocorrected to the last platform found in the recipe.
resolves #301
Signed-off-by: Tim Smith tsmith@chef.io