[SHACK-145] rename remote connection to target host #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given our usage, TargetHost makes more sense - it's a representation of the remote host that contains a connection, as opposed to being an actual connection itself.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
marcparadise
force-pushed
the
SHACK-145/multitarget/rename-remote-connection-to-target-host
branch
from
4c6d49b
to
3ea05e3
Compare
marcparadise
deleted the
SHACK-145/multitarget/rename-remote-connection-to-target-host
branch
marcparadise
restored the
SHACK-145/multitarget/rename-remote-connection-to-target-host
branch
chef-ci
deleted the
SHACK-145/multitarget/rename-remote-connection-to-target-host
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a global rename of Connection to TargetHost. TargetHost is a more accurate representation, since it exposes information about the host and actions to perform against the host. The connection itself is internal to it.
The class and 'connection/conn' variables + accessors were renamed to TargetHost and target_host respectively.