Aggressively clean up files in the workstation install #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The big one here is cleaning up the ext dir post gem compilation. That frees up 34 megs from the chef-workstation install Signed-off-by: Tim Smith <tsmith@chef.io>
Don't remove files that appbundler might need anywhere we have a bin dir Don't remove specs we use to test in the verify command This might seem overly complex, but the win is pretty substantial so I'd argue it's worth the trouble. Stats for this PR on my mac: 9.18% reduction in size of /opt/chef-workstation 10.63% reductions in /opt/chef-workstation file count Signed-off-by: Tim Smith <tsmith@chef.io>
This is one of the dirs leftover in backports Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
marcparadise
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might seem overly complex, but the win is pretty substantial so I'd argue it's worth the trouble. Stats for this PR on my mac:
9.28% reduction in size of /opt/chef-workstation (47.9 megs)
11.47% reductions in /opt/chef-workstation file count (4,934 files)