[SHACK-143] set the omnibus kitchen config to perform the omnibus build during converge #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbkidd
changed the title
cheeseplus
reviewed
Apr 12, 2018
omnibus/.kitchen.yml
Outdated
| @@ -7,40 +7,32 @@ driver: | |||
| cpus: 2 | |||
| memory: 2048 | |||
| storagectl: | |||
| - name: SATA Controller | |||
| - name: IDE Controller | |||
There was a problem hiding this comment.
most of the prevailing wisdom prefers SATA here, any specific reason for changing?
There was a problem hiding this comment.
My kitchen+vagrant+virtalbox was using IDE. 😬 But I can accept that this is my problem and take out this change.
There was a problem hiding this comment.
I'm fine with what works, was more curious if that was required/needed for a specific workaround/issue.
There was a problem hiding this comment.
I've taken this change out for the moment, leaving SATA. Maybe others using this kitchen will shake out which is the sensible default.
cheeseplus
reviewed
Apr 12, 2018
|
|
||
| depends 'omnibus' | ||
| depends 'apt', '~> 2.8' | ||
| depends 'freebsd', '~> 0.3' |
There was a problem hiding this comment.
If we're not supporting FreeBSD do we still need this?
Use a new cookbook to install the omnibus requirements and perform the build in a `kitchen converge <platform>`. Signed-off-by: Robb Kidd <robb@thekidds.org>
* update platforms for linuxes and versions intended to be supported; removes freebsd because it is not a platform supported initially * move the apt/yum default updating to the new builder cookbook default recipe where it can be handled with a case statement for platform * make the log level and build output configurable via attributes in the builder cookbook Signed-off-by: Robb Kidd <robb@thekidds.org>
robbkidd
force-pushed
the
robb/kitchen-auto-builds-a-pkg
branch
from
09cb9db
to
f89ad7e
Compare
marcparadise
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add's a new cookbook that handles the omnibus install requirements and then perform the build in a single
kitchen test <platform>orkitchen converge <platform>.Also: