Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHACK-122] support -v for version #72

Merged
merged 2 commits into from
Apr 10, 2018

Conversation

marcparadise
Copy link
Member

This lets -v work for showing version, adds additional version output test coverage, and expands 'help' coverage to include the case where no additional args are given and we print version + top level help.

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@marcparadise marcparadise requested a review from a team April 10, 2018 15:52
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@marcparadise marcparadise force-pushed the SHACK-122/support-dash-v-for-version branch from 2b5ad71 to bf6e230 Compare April 10, 2018 15:53
@@ -86,39 +146,4 @@

end
end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved these into the #run context, since they're all testing that path.

Copy link
Contributor

@jonsmorrow jonsmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcparadise marcparadise merged commit 730a885 into master Apr 10, 2018
@chef-ci chef-ci deleted the SHACK-122/support-dash-v-for-version branch April 10, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants