Aggressively prune files from the gems we install #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Paging @lamont-granquist since he probably has opinions here as well |
afiune
reviewed
Nov 5, 2019
Nope. We can only open PRs for each of the 100 gems to remove the files, but so far about 50% have said no since they want all their test files to ship in the gems. |
| CHANGES | ||
| CHANGELOG | ||
| README | ||
| Gemfile |
There was a problem hiding this comment.
think you broke appbundler here
There was a problem hiding this comment.
This is at the end once appbundler has already done its thing. Is that going to be a problem still?
| donate.png | ||
| Appraisals | ||
| website | ||
| *.gemspec |
|
seems fine other than those two |
See what we can do about our overall file size and counnt by removing non-library files from the package. Signed-off-by: Tim Smith <tsmith@chef.io>
We need to think through what this would do to appbundle udpating Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See what we can do about our overall file size and count by removing
non-library files from the package.
512MB - > 493MB. 3095 files removed
Signed-off-by: Tim Smith tsmith@chef.io