Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the Workstation App to run at boot on Windows #671

Merged
merged 7 commits into from
Feb 5, 2020
Merged

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Nov 4, 2019

If we want to keep folks up to date we should run this at boot. It seems
acceptable to have it do so on Windows while not doing it on every other
platform.

GH Issue: #819

Signed-off-by: Tim Smith tsmith@chef.io

@tas50 tas50 requested review from a team as code owners November 4, 2019 20:39

<ComponentRef Id="ChefWSAppAutostartShortcut" />
-->
<ComponentRef Id="ChefWSAppAutostartShortcut" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will start the Chef Workstation App? Maybe we need a build to verify this functionality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If everyone is ok with the concept I'll kick off an adhoc

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let us wait.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are ready to do a build! We want this change for this sprint...

tenor-225611003

@tyler-ball tyler-ball added this to the December 2 - December 13 milestone Dec 3, 2019
@tyler-ball
Copy link
Contributor

Waiting on validation for this one - want to try installing it on a Windows desktop under a non-admin user

@tyler-ball
Copy link
Contributor

tyler-ball commented Jan 24, 2020

We will review this PR and asses whether we can merge this in the current sprint without having feature parity with MacOS / *nix. Is it even possible, in a future PR, to get feature parity for this in *nix?

If we want to keep folks up to date we should run this at boot. It seems
acceptable to have it do so on Windows while not doing it on every other
platform.

Signed-off-by: Tim Smith <tsmith@chef.io>
@afiune
Copy link

afiune commented Feb 3, 2020

rebased from master and launched an ad hoc build

@afiune
Copy link

afiune commented Feb 3, 2020

This PR does what it suppose to do, add the WS App to the list of Startup Apps:
Screen Shot 2020-02-03 at 3 56 22 PM

I wonder if there is an easy tweak to start the app after install? 🤔 I'll do a quick read

Copy link

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me see if I can find an easy trick to start the WS app after install.

Salim Afiune added 2 commits February 3, 2020 18:36
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
@afiune
Copy link

afiune commented Feb 4, 2020

I have added a checkbox to launch the Chef Workstation App after the installation has been completed!

Screen Shot 2020-02-03 at 9 59 10 PM

tenor-201449750

@afiune
Copy link

afiune commented Feb 4, 2020

One more ad hoc build 🤞

@afiune afiune self-assigned this Feb 4, 2020
Copy link
Contributor Author

@tas50 tas50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@afiune
Copy link

afiune commented Feb 4, 2020

@tas50 indeed! Just waiting for the ad hoc build and a quick test!

tenor-129861833

@afiune afiune added the Type: Enhancement Adds new functionality. label Feb 5, 2020
Signed-off-by: Salim Afiune <afiune@chef.io>
@afiune afiune merged commit 683c4c5 into master Feb 5, 2020
@chef-expeditor chef-expeditor bot deleted the windows_at_boot branch February 5, 2020 23:35
@jonsmorrow
Copy link
Contributor

This was probably a 3 or 5 from a point perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants