Support for connecting to winrm over ssl #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-ball
approved these changes
Apr 5, 2018
There was a problem hiding this comment.
This LGTM. We may also want to support the self_signed option but we could add a new PR for that when we need it in the future
marcparadise
force-pushed
the
SHACK-118/ssl-winrm
branch
from
8f83c8a
to
ba0cf06
Compare
This adds the options --ssl-verify and --[no-]ssl-verify to permit WinRM connections over https. This also moves managing translation of connection parameters to RemoteConnection instead of having some pieces in Target and some in RemoteConnection. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
marcparadise
force-pushed
the
SHACK-118/ssl-winrm
branch
from
ba0cf06
to
e1fdc97
Compare
|
This is now updated with a '--[no]-ssl-verify' option and handling/instructions for ssl host verification failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to enable ssl connections for WinRM.
This still needs validation against a running WinRM instance with SSL enabled, and a minor update to
Target::Converge#perform_commandin order to make connection parameters testsable.Signed-off-by: Marc A. Paradise marc.paradise@gmail.com