Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a broken path in the omnibus build #488

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Fixing a broken path in the omnibus build #488

merged 1 commit into from
Sep 13, 2019

Conversation

tyler-ball
Copy link
Contributor

@tyler-ball tyler-ball commented Sep 13, 2019

Description

There is no longer a windows-env-customization folder, it got renamed to env-customization. We could fix this by 1) specifying the path instead of using the software definition name or 2) rename the software def to env-customization so the name matches the existing path.

Related Issue

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: tyler-ball <tball@chef.io>
@tyler-ball tyler-ball requested review from a team as code owners September 13, 2019 18:44
Copy link

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-124098568

@afiune
Copy link

afiune commented Sep 13, 2019

The adhoc build passed!!! Let's get this fix merged....

tenor-153412403

@afiune afiune merged commit 7f40622 into master Sep 13, 2019
@chef-expeditor chef-expeditor bot deleted the pipeline_fix branch September 13, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants