Add libGlesV2 to whitelist chef-workstation-app. #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently upgraded to electron v6 [1], which introduced this new dependency. Because we have not unpacked the electron build dependencies for inclusion into omnibus, we're adding this to the whitelist. Similar to the other whitelisted components, this means that chef-workstation-app will not run when they are missing on the target Linux system. We currently have a check in postinstall.sh that warns when this happens. [1] chef/chef-workstation-app@33b278d pour Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently upgraded to electron v6 [1], which introduced this new dependency.
Because we have not unpacked the electron build dependencies for
inclusion into omnibus, we're adding this to the whitelist.
Similar to the other whitelisted components, this means that
chef-workstation-app will not run when they are missing on the target
Linux system.
We currently have a check in postinstall.sh that warns when this
happens.
[1] chef/chef-workstation-app@33b278d
pour
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com
Description
Related Issue
Types of changes
Checklist: