Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an exception when remote CCR fails #44

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

marcparadise
Copy link
Member

This will help be ensuring the location of log files
that we refer to in the task failure message is quickly
available when a remote CCR fails.

before:
before

after:
after

Signed-off-by: Marc A. Paradise marc.paradise@gmail.com

@marcparadise marcparadise requested a review from a team April 2, 2018 16:16
@marcparadise marcparadise force-pushed the mp/raise-error-on-converge-fail branch from 0c23c31 to 137333b Compare April 2, 2018 16:17
@marcparadise
Copy link
Member Author

The phrasing has changed slightly from the screenshots: " Please examine the log file below for a detailed cause of failure.
"

This will help be ensuring the location of log files
that we refer to in the task failure message is quickly
available when a remote CCR fails.

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@marcparadise marcparadise force-pushed the mp/raise-error-on-converge-fail branch from 137333b to 4d6479b Compare April 2, 2018 16:19
Copy link
Contributor

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-110613906
Thanks for getting this fix in!

@marcparadise marcparadise merged commit 4ddfa46 into master Apr 2, 2018
@chef-ci chef-ci deleted the mp/raise-error-on-converge-fail branch April 2, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants