Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Got some more bug fixes #43

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Got some more bug fixes #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff93972
Values ike web URLs can take many forms, relax our validation
tyler-ball Mar 30, 2018
51112d1
Missed an accessor here
tyler-ball Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/chef-workstation/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ GIT
PATH
remote: .
specs:
chef-workstation (0.1.0)
chef-workstation (0.1.19)
mixlib-cli
mixlib-config
mixlib-install
Expand Down
2 changes: 1 addition & 1 deletion components/chef-workstation/lib/chef-workstation/command/target/converge.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def run(params)
end

# TODO raise wrapped errors that get formatted and displayed appropriately IE SHACK-105
ATTRIBUTE_MATCHER = /^([a-zA-Z0-9]+)=(\w+)$/
ATTRIBUTE_MATCHER = /^([a-zA-Z0-9]+)=(.+)$/
def validate_params(params)
if params.size < 3
raise OptionValidationError.new("CHEFVAL002")
Expand Down
2 changes: 1 addition & 1 deletion components/chef-workstation/lib/chef-workstation/ui/error_printer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
module ChefWorkstation::UI
# TODO - thi sis more of an error formatter...
class ErrorPrinter
attr_reader :pastel, :show_log, :show_stack, :exception
attr_reader :pastel, :show_log, :show_stack, :exception, :conn
# TODO define 't' as a method is a temporary workaround
# to ensure that text key lookups are testable.
def t
Expand Down
5 changes: 3 additions & 2 deletions components/chef-workstation/spec/unit/command/target/converge_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,14 @@

describe "#format_attributes" do
it "parses attributes into a hash" do
provided = %w{key1=value key2=1 key3=true key4=FaLsE key5=0777}
provided = %w{key1=value key2=1 key3=true key4=FaLsE key5=0777 key6=https://some.website}
expected = {
"key1" => "value",
"key2" => 1,
"key3" => true,
"key4" => false,
"key5" => "0777"
"key5" => "0777",
"key6" => "https://some.website",
}
expect(cmd.format_attributes(provided)).to eq(expected)
end
Expand Down