Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHACK-358] update docs and navigation for chef.sh #245

Merged
merged 7 commits into from
Oct 2, 2018

Conversation

marcparadise
Copy link
Member

@marcparadise marcparadise commented Sep 19, 2018

Description

This restructures the CLI reference documents to be under the
heading "Tools Reference" and adds placeholders for key chefdk tools.

Previously, the "CLI Reference" heading was under "Chef Workstation" and
contained only the chef-run CLI reference. This change puts Workstation
tool CLI reference docs under a single heading to make them easier to
find.

The reference doc for chef-run is complete, but the other components currently
contain links over the their docs.chef.io (or inspec.io/docs)
counterparts until the docs migration effort is complete.
capture
capture

Check List

  • PR title is a worthy inclusion in the CHANGELOG
  • You have locally validated the change
  • www/site/content/docs/ has been updated with any relevant changes:
      • new or changed error messages in 'troubleshooting.md'
      • new or changed CLI flags in cli-reference.md

@marcparadise marcparadise requested a review from a team September 19, 2018 16:07
@@ -0,0 +1,12 @@
+++
title = "Tools Reference - berks"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems overkill to have Tools Reference on each page when that will be clearly indicated by the Nav

Copy link
Member Author

@marcparadise marcparadise Sep 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on that - what I actually wanted was to get the full name in the title, "Chef Workstation Tools Reference - TOOLNAME", while the menu item and the page heading just have the tool name.
I'll push the update to be just the tool name, and can open another card to straighten out titles on the browser titlebar (which will be only TOOLNAME with that change), vs what's shown on the menu and in the content.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, new screencaps inbound

@marcparadise marcparadise force-pushed the SHACK-358/update-docs-and-navigation branch from b587192 to 943e6f6 Compare September 19, 2018 16:55
@kagarmoe
Copy link

I'd like to just call it "Reference", in keeping with our other docs sites.

@marcparadise
Copy link
Member Author

marcparadise commented Sep 19, 2018

@kagarmoe thanks, I've updated and refreshed the screen captures.

This also updates the slug, which isn't in the capture - they're now looking like this:

https://chef.sh/docs/reference/TOOLNAME

@marcparadise marcparadise force-pushed the SHACK-358/update-docs-and-navigation branch from 943e6f6 to a58ac1f Compare September 19, 2018 18:46
This commit restructures the CLI reference documents to be under the
heading "Tools Reference" and adds placeholders for key chefdk tools.

Previously, the "CLI REference" heading was under "Chef Workstation" and
contained only the chef-run CLI reference. This change puts Workstation
tool CLI reference docs under a single heading to make them easier to
find.

The reference doc for chef-run is complete, but the other components currently
contain links over the their docs.chef.io (or inspec.io/docs)
counterparts.

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@marcparadise marcparadise force-pushed the SHACK-358/update-docs-and-navigation branch from a58ac1f to 74bfff9 Compare September 21, 2018 15:56
Copy link
Contributor

@jonsmorrow jonsmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonsmorrow
Copy link
Contributor

@kagarmoe I'd like to get your sign off before we merge this.

@kagarmoe kagarmoe merged commit d83d48d into master Oct 2, 2018
@chef-ci chef-ci deleted the SHACK-358/update-docs-and-navigation branch October 2, 2018 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants