Capitalization issue in Windows package (wix)

[tyler-ball]

Description

Fixes it

Issues Resolved

N/A

Check List

• PR title is a worthy inclusion in the CHANGELOG
• You have locally validated the change
• www/site/content/docs/ has been updated with any relevant changes:
  • • new or changed error messages in 'troubleshooting.md'
  • • new or changed CLI flags in cli-reference.md

Signed-off-by: tyler-ball tball@chef.io

[stuartpreston]

Yes, these directories need to be public properties (uppercase) - so this is one way to fix it but it will generate an ICE99 warning at compile time.

I checked in Omnibus and we seem to ignore any warnings being generated (would give a return code of 204) - see https://github.com/chef/omnibus/blob/7ac8251d5025dce1f93c3da85b52f55c6a9b94ec/lib/omnibus/packagers/msi.rb#L71

So, whilst this is a valid fix I think a better fix (avoiding warnings) that should be applied here and in ChefDK would be something like:

  <SetDirectory Id="WINDOWSVOLUME" Value="[WindowsVolume]"/>
  <Directory Id="TARGETDIR" Name="SourceDir">
    <Directory Id="WINDOWSVOLUME">
  ...

(ref: http://kentie.net/article/wixtipstricks/)

[tyler-ball]

@stuartpreston Updated!