[SHACK-212] [GH #175] Always expand host to include full user info #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
force-pushed
the
mp/password-flag-fix
branch
from
93158b9
to
4e48eca
Compare
marcparadise
changed the title
marcparadise
force-pushed
the
mp/password-flag-fix
branch
from
4e48eca
to
6053d8c
Compare
marcparadise
changed the title
To provide a consistent experience with multi- and single-target, we will always construct a fully qualified url in the form: proto://user-info@target Where user-info is "username:password" (ref: RFC 3928[1] s. 3.2.1) We no longer pass the user or password option into train, so that there is no conflict between those values and the values embedded in the url. This ensures that train will only have one set of credentials to work with per host, and won't do surprising things. A blank username will be expanded in the form ":password@host.com" and a blank password will be supplied in the form "username:@host.com", both of which are valid under the RFC. This fixes github issue #175 [1] https://www.ietf.org/rfc/rfc3986.txt Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>Always expand host to include full user info Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
marcparadise
force-pushed
the
mp/password-flag-fix
branch
from
6053d8c
to
878ec5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always expand host to include full user info
To provide a consistent experience with multi- and single-target,
we will always construct a fully qualified url in the form:
proto://user-info@target
Where user-info is "username:password" (ref: RFC 3928[1])
We no longer pass the user or password option into train, so that there
is no conflict between those values and the values embedded in the url.
This ensures that train will only have one set of credentials to work
with per host, and won't do surprising things.
A blank username will be expanded in the form ":password@host.com" and
a blank password will be supplied in the form "username:@host.com", both
of which are valid under the RFC.
This fixes github issue #175
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com