Revert train to 1.4.6, update sudo error checks #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
force-pushed
the
mp/revert-train-again-1.4.6
branch
from
1b32890
to
8f41bce
Compare
jonsmorrow
approved these changes
May 21, 2018
| when :bad_sudo_password then "CHEFTRN004" | ||
| when :sudo_command_not_found then ["CHEFTRN005", sudo_command] | ||
| when :sudo_no_tty then "CHEFTRN006" | ||
| # Comments below show the original_exception.reason values ot check for instead of strings, |
This reverts train to 1.4.6. Later versions introduce a gcp dependency that does not cleanly pass omnibus health checks. While that is being resolved, we'll continue to stick to 1.4.6. We were using the Train::Error#reason field added in 1.4.12; this PR updates error handling to do string-based matching of the messages provided by train instead. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
marcparadise
force-pushed
the
mp/revert-train-again-1.4.6
branch
from
8f41bce
to
c0781c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts train to 1.4.6. Later versions introduce a gcp
dependency that does not cleanly pass omnibus health checks. While that
is being resolved, we'll continue to stick to 1.4.6.
We were using the Train::Error#reason field added in 1.4.12; this PR
updates error handling to do string-based matching of the messages
provided by train instead.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com