Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Im/migrate workstation docs #1471

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Im/migrate workstation docs #1471

merged 4 commits into from
Sep 15, 2020

Conversation

IanMadd
Copy link
Contributor

@IanMadd IanMadd commented Sep 15, 2020

Description

Docs overhaul (again):

  • moves documentation deployed on doc.chef.io from www to docs-chef-io.
  • moves docs in docs to dev-docs
  • updates CODEOWNERS
  • removes old chef.sh configuration from .gitignore

Netlify preview won't work
The subdirectory that Netlify uses to do a preview deploy is set from the Netlify site and can't be changed with a config file. That means that Netlify will look in www to preview this PR and fail when it can't find it. I'll update the configuration after this is merged.

Related Issue

chef/release-engineering#1277

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

IanMadd added 3 commits September 15, 2020 13:29
Signed-off-by: IanMadd <imaddaus@chef.io>
Signed-off-by: IanMadd <imaddaus@chef.io>
Signed-off-by: IanMadd <imaddaus@chef.io>
@IanMadd IanMadd added the Aspect: Documentation How do we use this project? label Sep 15, 2020
@IanMadd IanMadd requested review from a team as code owners September 15, 2020 20:38
@netlify
Copy link

netlify bot commented Sep 15, 2020

Deploy preview for chef-workstation processing.

Building with commit b1bb109

https://app.netlify.com/sites/chef-workstation/deploys/5f6128dc647e530008ab103e

@IanMadd IanMadd requested a review from a team as a code owner September 15, 2020 20:47
Signed-off-by: IanMadd <imaddaus@chef.io>
@tyler-ball tyler-ball merged commit 87adeab into master Sep 15, 2020
@tas50 tas50 deleted the im/migrate_workstation_docs branch September 29, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Documentation How do we use this project?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants