-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shack 199/rename to chef run #131
Conversation
45a5030
to
5f43f06
Compare
dependency "rubygems" | ||
dependency "bundler" | ||
dependency "ruby" | ||
dependency "appbundler" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add chef-dk
to the chef-run
software def dependencies.
This will ensure at the lowest appropriate layer that our DK software def has done the needful for the retrieval, build, and install of the chef-dk
gem on which the new chef-run
gem depends.
5dd708d
to
6fdc19b
Compare
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
6fdc19b
to
3665038
Compare
components/chef-run/i18n/en.yml
Outdated
chef-run myec2node path/to/cookbook/recipe.rb | ||
chef-run myec2node,myec2node2 path/to/cookbook | ||
chef-run myec2node[1:2] cookbook_name | ||
chef-run myec2node cookbook_name::recipe_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chef-cli
's en.yml
got an update after this was copied.
Need to s/myec2node/web01/
in the usage_full:
section.
components/chef-run/i18n/en.yml
Outdated
Cookbook path is '%1'. | ||
|
||
CHEFVAL006: | | ||
Cookbook '%1' could not be found in any of the following directorys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/directorys/directories/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Longer term, I think we'll benefit by separating out a lot of the core 'framework' stuff and exposing it in the chef-cli component as a gem; then 'chef-run' and future commands can focus on providing their specific features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of updates to chef-run's en.yml to bring it up to date with changes to chef-cli's en.yml, then I think it's good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
components/chef-run/Gemfile.lock
needs updating with the new source for chef-telemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good (pending gemfile.lock update)
Creates a new chef-run component and brings over a a bunch of stuff from chef-cli.
Left todo:
chef
from chef-cli ending up on path by default^ That should be in a different pr