Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shack 199/rename to chef run #131

Merged
merged 12 commits into from
May 17, 2018
Merged

Conversation

jonsmorrow
Copy link
Contributor

@jonsmorrow jonsmorrow commented May 16, 2018

Creates a new chef-run component and brings over a a bunch of stuff from chef-cli.

Left todo:

  • Add additional tests
  • Make sure telemetry calls are in the right places with refactor
  • Prevent chef from chef-cli ending up on path by default
  • Cleanup chef-cli to have chef run forward to chef-run
    ^ That should be in a different pr

@jonsmorrow jonsmorrow requested a review from a team May 16, 2018 09:31
@jonsmorrow jonsmorrow force-pushed the SHACK-199/rename_to_chef-run branch 2 times, most recently from 45a5030 to 5f43f06 Compare May 16, 2018 10:22
dependency "rubygems"
dependency "bundler"
dependency "ruby"
dependency "appbundler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add chef-dk to the chef-run software def dependencies.

This will ensure at the lowest appropriate layer that our DK software def has done the needful for the retrieval, build, and install of the chef-dk gem on which the new chef-run gem depends.

@jonsmorrow jonsmorrow force-pushed the SHACK-199/rename_to_chef-run branch 4 times, most recently from 5dd708d to 6fdc19b Compare May 17, 2018 14:35
Jon Morrow added 10 commits May 17, 2018 08:39
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
Signed-off-by: Jon Morrow <jmorrow@chef.io>
@jonsmorrow jonsmorrow force-pushed the SHACK-199/rename_to_chef-run branch from 6fdc19b to 3665038 Compare May 17, 2018 15:43
chef-run myec2node path/to/cookbook/recipe.rb
chef-run myec2node,myec2node2 path/to/cookbook
chef-run myec2node[1:2] cookbook_name
chef-run myec2node cookbook_name::recipe_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chef-cli's en.yml got an update after this was copied.

Need to s/myec2node/web01/ in the usage_full: section.

Cookbook path is '%1'.

CHEFVAL006: |
Cookbook '%1' could not be found in any of the following directorys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/directorys/directories/

marcparadise
marcparadise previously approved these changes May 17, 2018
Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Longer term, I think we'll benefit by separating out a lot of the core 'framework' stuff and exposing it in the chef-cli component as a gem; then 'chef-run' and future commands can focus on providing their specific features.

Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of updates to chef-run's en.yml to bring it up to date with changes to chef-cli's en.yml, then I think it's good to go.

marcparadise
marcparadise previously approved these changes May 17, 2018
Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components/chef-run/Gemfile.lock needs updating with the new source for chef-telemetry

cheeseplus
cheeseplus previously approved these changes May 17, 2018
Copy link

@cheeseplus cheeseplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (pending gemfile.lock update)

@jonsmorrow jonsmorrow dismissed stale reviews from cheeseplus and marcparadise via dfe63f1 May 17, 2018 17:38
@jonsmorrow jonsmorrow merged commit c6cbe0e into master May 17, 2018
@chef-ci chef-ci deleted the SHACK-199/rename_to_chef-run branch May 17, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants