[SHACK-200] pin train to pre-GCP version #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Train 1.4.7 added Google GCP libraries. The google-protobuf gem does not coexist in an omnibus build well because its C-extensions build seemingly for every version of Ruby which are then caught by the omnibus health check for .so files built against non-existent libraries. Example of failure can be found on protocolbuffers/protobuf#4210 Applying this pin WHICH SHOULD TOTALLY BE REMOVED when we have solved for omnibus packaging of google-protobuf. Signed-off-by: Robb Kidd <robb@thekidds.org>
|
Running an omnibus build locally to confirm. |
|
🎉 Local omnibus build did not error on google-protobuf. |
robbkidd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Train 1.4.7 added Google GCP libraries. The google-protobuf gem does not coexist in an omnibus build well because its C-extensions build seemingly for every version of Ruby which are then caught by the omnibus health check for .so files built against non-existent libraries.
Example of failure can be found on protocolbuffers/protobuf#4210
Applying this pin WHICH SHOULD TOTALLY BE REMOVED when we have solved for omnibus packaging of google-protobuf.