Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows 8 Tester #1262

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Add Windows 8 Tester #1262

merged 2 commits into from
Jun 29, 2020

Conversation

snapp
Copy link
Contributor

@snapp snapp commented Jun 9, 2020 •
edited by jonsmorrow
Loading

Description

This PR just adds Windows 8 support, an adhoc build showing it working as expected can be found here:

https://buildkite.com/chef/chef-chef-workstation-master-omnibus-adhoc/builds/281

Signed-off-by: Christopher A. Snapp csnapp@chef.io

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Aha! Link: https://chef.aha.io/features/SH-2221

@snapp snapp requested a review from a team as a code owner June 9, 2020 16:42
@snapp snapp self-assigned this Jun 9, 2020
@netlify
Copy link

netlify bot commented Jun 9, 2020 •
edited
Loading

Deploy preview for chef-workstation ready!

Built with commit b64e8b8

https://deploy-preview-1262--chef-workstation.netlify.app

@snapp @tas50
Add Windows 8 Tester
f6fc819 
Signed-off-by: Christopher A. Snapp <csnapp@chef.io>
@tyler-ball tyler-ball merged commit 8508e1d into master Jun 29, 2020
@tyler-ball tyler-ball deleted the csnapp/add_win8 branch June 29, 2020 21:50
@jonsmorrow jonsmorrow added the Epic label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-ball tyler-ball tyler-ball approved these changes

Assignees

@snapp snapp

Labels
Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snapp @tyler-ball @jonsmorrow