Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working around a build time segfault with FFI 1.13 #1246

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Working around a build time segfault with FFI 1.13 #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/gems/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@

source "https://rubygems.org"

# We found a segfault in ffi 1.13
gem "ffi", "< 1.13.0"

group(:omnibus_package, :development, :test) do
# Require a minimum version that is packaged in the Ruby install, so we do
# not install old unecessary versions. When we bump Ruby we need to look
Expand Down
7 changes: 4 additions & 3 deletions components/gems/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,9 +393,9 @@ GEM
faraday (>= 0.7.4, < 1.0)
fauxhai-ng (8.2.0)
net-ssh
ffi (1.13.0)
ffi (1.13.0-x64-mingw32)
ffi (1.13.0-x86-mingw32)
ffi (1.12.1)
ffi (1.12.1-x64-mingw32)
ffi (1.12.1-x86-mingw32)
ffi-libarchive (1.0.0)
ffi (~> 1.0)
ffi-rzmq (2.0.7)
Expand Down Expand Up @@ -1050,6 +1050,7 @@ DEPENDENCIES
docker-api
ed25519
fauxhai-ng (~> 8)
ffi (< 1.13.0)
ffi-libarchive
ffi-rzmq-core
foodcritic (>= 16.2)
Expand Down
3 changes: 3 additions & 0 deletions omnibus/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ gem "artifactory"

gem "pedump"

# We found a segfault in ffi 1.13
gem "ffi", "< 1.13.0"

# This development group is installed by default when you run `bundle install`,
# but if you are using Omnibus in a CI-based infrastructure, you do not need
# the Test Kitchen-based build lab. You can skip these unnecessary dependencies
Expand Down
7 changes: 4 additions & 3 deletions omnibus/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,9 @@ GEM
erubis (2.7.0)
faraday (1.0.1)
multipart-post (>= 1.2, < 3)
ffi (1.13.0)
ffi (1.13.0-x64-mingw32)
ffi (1.13.0-x86-mingw32)
ffi (1.12.2)
ffi (1.12.2-x64-mingw32)
ffi (1.12.2-x86-mingw32)
ffi-libarchive (1.0.0)
ffi (~> 1.0)
ffi-win32-extensions (1.0.3)
Expand Down Expand Up @@ -393,6 +393,7 @@ PLATFORMS
DEPENDENCIES
artifactory
berkshelf (>= 7.0)
ffi (< 1.13.0)
kitchen-vagrant
omnibus!
omnibus-software!
Expand Down