Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pry-stack_explorer to >= 0.5.1 #1225

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

clintoncwolfe
Copy link
Collaborator

@clintoncwolfe clintoncwolfe commented May 22, 2020

Description

Pins pry-stack_explorer to silence warnings that are emitted when running inspec shell. This version drops support for ruby 2.5.

Previously this PR used a fork, but they fixed it overnight, so, we'll use the new gem.

Updates the Gemfile.lock, with the usual bumps.

Signed-off-by: Clinton Wolfe clintoncwolfe@gmail.com

Related Issue

inspec/inspec#5042 inspec shell warning issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Aha! Link: https://chef.aha.io/features/SH-2025

@clintoncwolfe clintoncwolfe requested review from a team as code owners May 22, 2020 01:41
@netlify
Copy link

netlify bot commented May 22, 2020

Deploy preview for chef-workstation ready!

Built with commit cb1206e

https://deploy-preview-1225--chef-workstation.netlify.app

@james-stocks
Copy link

I left a comment on the InSpec issue; I think this is already fixed in pry-stack_explorer
inspec/inspec#5042 (comment)

jstocks@phobos inspec % ./inspec-bin/bin/inspec shell 
/opt/chef-workstation/embedded/lib/ruby/gems/2.7.0/gems/pry-byebug-3.9.0/lib/pry-byebug/pry_ext.rb:13: warning: __FILE__ in eval may not return location in binding; use Binding#source_location instead
/opt/chef-workstation/embedded/lib/ruby/gems/2.7.0/gems/pry-stack_explorer-0.4.9.3/lib/pry-stack_explorer/when_started_hook.rb:63: warning: in `eval'
/opt/chef-workstation/embedded/lib/ruby/gems/2.7.0/gems/pry-0.13.1/lib/pry/core_extensions.rb:45: warning: __FILE__ in eval may not return location in binding; use Binding#source_location instead
/opt/chef-workstation/embedded/lib/ruby/gems/2.7.0/gems/pry-stack_explorer-0.4.9.3/lib/pry-stack_explorer/when_started_hook.rb:63: warning: in `eval'
Welcome to the interactive InSpec Shell
To find out how to use it, type: help

You are currently running on:

    Name:      mac_os_x
    Families:  darwin, bsd, unix, os
    Release:   19.4.0
    Arch:      x86_64

inspec> exit
jstocks@phobos inspec % chef gem install pry-stack_explorer
Fetching pry-stack_explorer-0.5.1.gem
Successfully installed pry-stack_explorer-0.5.1
1 gem installed
jstocks@phobos inspec % ./inspec-bin/bin/inspec shell      
Welcome to the interactive InSpec Shell
To find out how to use it, type: help

You are currently running on:

    Name:      mac_os_x
    Families:  darwin, bsd, unix, os
    Release:   19.4.0
    Arch:      x86_64

inspec> 

...however the PR for the fix indicates that pry-stack_explorer 0.5 no longer supports Ruby 2.5... which may not be an issue for workstation if it only uses ruby 2.7?

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe clintoncwolfe changed the title Use forked copy of pry-stack_explorer Pin pry-stack_explorer to >= 0.5.1 May 22, 2020
@clintoncwolfe
Copy link
Collaborator Author

^^ Updated PR to use newly released gem rather than our now-unneeded fork.

@tyler-ball tyler-ball merged commit d348f57 into master May 22, 2020
@tyler-ball tyler-ball deleted the cw/fork-pry-stack_explorer branch May 22, 2020 21:09
@jonsmorrow jonsmorrow added the Epic label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants