Take out the Ruby 2.4+ gate in the omnibus def #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for chef-workstation ready! Built with commit eab31bf |
tyler-ball
reviewed
May 12, 2020
omnibus/verification/verify.rb
Outdated
| @@ -194,10 +194,10 @@ def components | |||
|
|
|||
| add_component "chef-apply" do |c| | |||
| c.gem_base_dir = "chef-apply" | |||
| # c.unit_test do | |||
There was a problem hiding this comment.
Can you try uncommenting these and running an ad-hoc build? I found some of our other commented out verifications have started passing recently.
There's no need for this anymore. Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tyler-ball
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need for this anymore.
Signed-off-by: Tim Smith tsmith@chef.io
Aha! Link: https://chef.aha.io/features/SH-1850