Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chef-sugar helpers are now in chef-utils #1165

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

btm
Copy link
Contributor

@btm btm commented May 11, 2020

chef-utils (from chef/chef/chef-utils) is included as part of core chef
now and includes most of the helpers that used to be separately shipped
in the chef-sugar library. We no longer ship the chef-sugar library and
thus no longer need to test it.

Aha! Link: https://chef.aha.io/features/SH-1838

chef-utils (from chef/chef/chef-utils) is included as part of core chef
now and includes most of the helpers that used to be separately shipped
in the chef-sugar library. We no longer ship the chef-sugar library and
thus no longer need to test it.

Signed-off-by: Bryan McLellan <btm@loftninjas.org>
@btm btm requested review from tas50 and tyler-ball May 11, 2020 20:03
@btm btm requested review from a team as code owners May 11, 2020 20:03
@netlify
Copy link

netlify bot commented May 11, 2020

Deploy preview for chef-workstation ready!

Built with commit 548189a

https://deploy-preview-1165--chef-workstation.netlify.app

@tas50
Copy link
Contributor

tas50 commented May 11, 2020

I think we're good to pull this from workstation at this point. We should definitely think about why we shipped it in the DK / workstation releases originally. I can't think of why we'd need it there in the first place.

@lamont-granquist
Copy link
Contributor

I think I added it to DK originally and it was just because a large number of people used it

@tyler-ball tyler-ball merged commit d34381e into master May 11, 2020
@chef-expeditor chef-expeditor bot deleted the btm/sugar-is-utils branch May 11, 2020 21:18
@jonsmorrow jonsmorrow added the Epic label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants