Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows msys2_path to custom installed msys2 lookup first #1145

Merged
merged 1 commit into from
May 5, 2020

Conversation

jaymalasinha
Copy link
Contributor

@jaymalasinha jaymalasinha commented May 1, 2020

This PR is in preparation for introducing MSYS_INSTALL_DIR environment variable in next release of omnibus-toolchain. We do not ship msys2 for windows in omnibus-toolchain anymore, so this variable sets the PATH where msys2 is installed on the AMI

Signed-off-by: Jaymala Sinha jsinha@chef.io

Description

Set msys2_path to the path defined by MSYS_INSTALL_DIR for Windows builds

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Aha! Link: https://chef.aha.io/features/SH-1714

This PR is in preparation for introducing MSYS_INSTALL_DIR environment variable in next release of omnibus-toolchain. We do not ship msys2 for windows in omnibus-toolchain anymore, so this variable sets the PATH where msys2 is installed on the AMI

Signed-off-by: Jaymala Sinha <jsinha@chef.io>
@jaymalasinha jaymalasinha requested review from a team as code owners May 1, 2020 20:01
@netlify
Copy link

netlify bot commented May 1, 2020

Deploy preview for chef-workstation ready!

Built with commit dbfa347

https://deploy-preview-1145--chef-workstation.netlify.app

@tyler-ball
Copy link
Contributor

Running an ad-hoc build to test this

@tyler-ball tyler-ball merged commit 9830605 into master May 5, 2020
@tyler-ball tyler-ball deleted the jsinha/msys2_updt branch May 5, 2020 06:20
@jonsmorrow jonsmorrow added the Epic label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants