Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix netlify.toml file #1132

Merged
merged 4 commits into from
Apr 28, 2020
Merged

Fix netlify.toml file #1132

merged 4 commits into from
Apr 28, 2020

Conversation

IanMadd
Copy link
Contributor

@IanMadd IanMadd commented Apr 28, 2020 •
edited by jonsmorrow
Loading

Signed-off-by: IanMadd imaddaus@chef.io

Fix a couple Netlify issues.

Description

  • in the netlify.conig build.processing was in there twice but should be once.
  • rename www/netlify_production/_index.html --> www/netlify_production/index.html

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Aha! Link: https://chef.aha.io/features/SH-1629

Fix netlify.toml file
a4b7b4b 
Signed-off-by: IanMadd <imaddaus@chef.io>
@IanMadd IanMadd added the Aspect: Documentation How do we use this project? label Apr 28, 2020
@IanMadd IanMadd requested review from a team as code owners April 28, 2020 00:14
@netlify
Copy link

netlify bot commented Apr 28, 2020 •
edited
Loading

Deploy preview for chef-workstation ready!

Built with commit 94a303b

https://deploy-preview-1132--chef-workstation.netlify.app

IanMadd and others added 3 commits April 27, 2020 17:16
Fix publish directory in netlify.toml
1c62bb5 
Signed-off-by: IanMadd <imaddaus@chef.io>
rename index.html
b8bf702 
Signed-off-by: IanMadd <imaddaus@chef.io>
@tyler-ball
Merge branch 'master' into im/fix_netlify_config
94a303b
@tyler-ball tyler-ball merged commit 2ad29c1 into master Apr 28, 2020
@chef-expeditor chef-expeditor bot deleted the im/fix_netlify_config branch April 28, 2020 19:52
@jonsmorrow jonsmorrow added Epic and removed Aspect: Documentation How do we use this project? labels Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-ball tyler-ball tyler-ball approved these changes

Assignees
No one assigned
Labels
Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanMadd @tyler-ball @jonsmorrow