Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to date based versioning #1112

Merged
merged 4 commits into from
Apr 26, 2020
Merged

Switching to date based versioning #1112

merged 4 commits into from
Apr 26, 2020

Conversation

tyler-ball
Copy link
Contributor

@tyler-ball tyler-ball commented Apr 21, 2020 •
edited by jonsmorrow
Loading

Description

Our original plan was to use year.month.build_number but Windows
does not support 2020 as a major version number
(https://docs.microsoft.com/en-us/windows/win32/msi/productversion?redirectedfrom=MSDN)
so instead we are using a short year for the major version (21 for 2021).

Related Issue

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Aha! Link: https://chef.aha.io/features/SH-1581

@tyler-ball tyler-ball requested review from a team as code owners April 21, 2020 03:43
@tyler-ball tyler-ball requested a review from a team as a code owner April 23, 2020 19:39
@clintoncwolfe
Copy link
Collaborator

I've tested the determine_version.sh script under the expeditor docker image and it (correctly?) increments the VERSION file each time it executes. Year and Month are always current.

@tyler-ball tyler-ball mentioned this pull request Apr 23, 2020
Closed
33 tasks
tyler-ball and others added 4 commits April 24, 2020 13:44
@tyler-ball
Switching to date based versioning
de44b49 
Our original plan was to use `year.month.build_number` but Windows
does not support `2020` as a major version number
(https://docs.microsoft.com/en-us/windows/win32/msi/productversion?redirectedfrom=MSDN)
so instead we are using a short year for the major version (`21` for `2021`).

Signed-off-by: tyler-ball <tball@chef.io>
@clintoncwolfe @tyler-ball
A script to update the VERSION file when merging
de49c94 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@tyler-ball
Remove ability to bump major and minor version via Github
b4ea428 
Signed-off-by: tyler-ball <tball@chef.io>
@tyler-ball
Reseting build number to 1 in prep for merging this
eaf674d 
Signed-off-by: tyler-ball <tball@chef.io>
@tyler-ball tyler-ball force-pushed the major_version_date branch 2 times, most recently from 58d2927 to eaf674d Compare April 26, 2020 18:20
@tyler-ball tyler-ball merged commit 580a55a into master Apr 26, 2020
@chef-expeditor chef-expeditor bot deleted the major_version_date branch April 26, 2020 18:21
@jonsmorrow jonsmorrow added the Epic label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcparadise marcparadise marcparadise approved these changes

Assignees
No one assigned
Labels
Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tyler-ball @clintoncwolfe @marcparadise @jonsmorrow