Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows 10 Tester #1072

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Add Windows 10 Tester #1072

merged 2 commits into from
Apr 9, 2020

Conversation

snapp
Copy link
Contributor

@snapp snapp commented Apr 6, 2020 •
edited by jonsmorrow
Loading

Description

This PR just adds a Windows 10 tester and has been verified to work in this adhoc build:

https://buildkite.com/chef/chef-chef-workstation-master-omnibus-adhoc/builds/216

Signed-off-by: Christopher A. Snapp csnapp@chef.io

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Aha! Link: https://chef.aha.io/features/SH-1330

@snapp snapp requested a review from a team as a code owner April 6, 2020 23:51
@snapp
Add Windows 10 Tester
6f3180f 
Signed-off-by: Christopher A. Snapp <csnapp@chef.io>
tyler-ball
tyler-ball approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we merge this will we automatically get Windows 10 'artifacts' (EG, that operating system listed for Chef Workstation on downloads.chef.io)?

@snapp
Copy link
Contributor Author

snapp commented Apr 9, 2020

Yes, you should see Windows 10 as a downloadable option.

@tyler-ball tyler-ball merged commit 0179675 into master Apr 9, 2020
@tyler-ball tyler-ball deleted the csnapp/add_win10 branch April 9, 2020 20:40
@jonsmorrow jonsmorrow added the Epic label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiahsnapp jeremiahsnapp jeremiahsnapp approved these changes

@tyler-ball tyler-ball tyler-ball approved these changes

@jaymalasinha jaymalasinha jaymalasinha approved these changes

Assignees
No one assigned
Labels
Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snapp @jeremiahsnapp @tyler-ball @jaymalasinha @jonsmorrow