multitarget fixes #107
Merged
multitarget fixes #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsmorrow
previously approved these changes
May 4, 2018
Fully specified host (eg ssh://user:pass@host) was failing to parse ranges because '@' was not recognized as a valid character. Also corrected an issue in previously unhit error_printer logic where we were using the wrong variable name. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
A given range is automatically sorted so that the lower value comes first, but we didn't correctly handle ASCII sorts of integers-as-strings resulting in a ruby Range that could not be iterated and an incorrect error message (CHEFRANGE002) as a side effect. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
marcparadise
force-pushed
the
mp/multitarget-fixes
branch
from
ba5c64e
to
4d9dc29
Compare
|
Review dismissed with rebase. However a little more work is needed - we will still fail to parse in the likely scenario of a fully qualified host w/ a password containing special characters. I'll push up an additional commit; marking this WIP/no-merge for now. |
|
The addiitonal special character changes are coupled to train changes; I will make those as a separate PR. This one is good to go. |
tyler-ball
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issues discovered in final vetting of multitarget.
The individual commit messages have some more details.